Houston, we have warnings.

Bernhard Fischer rep.nop at aon.at
Tue Dec 13 10:59:47 UTC 2005


On Mon, Dec 12, 2005 at 10:08:07PM -0600, Rob Landley wrote:

>/home/landley/busybox/busybox/coreutils/head.c: In function `head_main':
>/home/landley/busybox/busybox/coreutils/head.c:88: warning: label `GET_COUNT' 
>defined but not used

"fixed" in r12867

>/home/landley/busybox/busybox/coreutils/tail.c: In function `tail_main':
>/home/landley/busybox/busybox/coreutils/tail.c:145: warning: label `GET_COUNT' 
>defined but not used

"fixed" in r12867

>/home/landley/busybox/busybox/networking/ifupdown.c:306: warning: `execute' 
>defined but not used

I have the attached *untested* snippet in my tree... please ci if your
testing shows that it is ok, TIA.

>/home/landley/busybox/busybox/networking/zcip.c:76: warning: useless keyword 
>or type name in empty declaration

My fault, done.

>/home/landley/busybox/busybox/util-linux/more.c: In function `more_main':
>/home/landley/busybox/busybox/util-linux/more.c:71: warning: `cin_fileno' 
>might be used uninitialized in this function

Just as a mid-term heads up:
gcc-3.x chokes on these for IMA-mode (not a real issue for 1.1.0):
/tmp/ccDqsNz4.o: warning: multiple common of `rootdev'
/tmp/ccODTjCo.o: warning: previous common is here
/tmp/ccDqsNz4.o: In function `switch_root_main':
switch_root.c:(.text+0x104): multiple definition of `switch_root_main'
/tmp/ccODTjCo.o:switch_root.c:(.text+0x104): first defined here

-------------- next part --------------
diff -X excl -rduNp busybox.oorig/networking/ifupdown.c busybox/networking/ifupdown.c
--- busybox.oorig/networking/ifupdown.c	2005-10-28 13:22:34.000000000 +0200
+++ busybox/networking/ifupdown.c	2005-12-12 11:16:09.000000000 +0100
@@ -141,6 +141,8 @@ static int count_netmask_bits(char *dott
 }
 #endif
 
+#if ENABLE_FEATURE_IFUPDOWN_IPV4 || ENABLE_FEATURE_IFUPDOWN_IPV6 || \
+	ENABLE_FEATURE_IFUPDOWN_IPX
 static void addstr(char **buf, size_t *len, size_t *pos, char *str, size_t str_length)
 {
 	if (*pos + str_length >= *len) {
@@ -319,6 +321,7 @@ static int execute(char *command, struct
 	}
 	return(1);
 }
+#endif
 
 #ifdef CONFIG_FEATURE_IFUPDOWN_IPX
 static int static_up_ipx(struct interface_defn_t *ifd, execfn *exec)



More information about the busybox mailing list