[BusyBox] Re: [BusyBox-cvs] [BusyBox 0000405]: [PATCH] nfs mount and options are broken in svn

[Rob Landley]

On Sunday 28 August 2005 01:49, Mike Frysinger wrote:
> On Saturday 27 August 2005 08:06 am, bugs at busybox.net wrote:
> > The following issue has been SUBMITTED.
> > ======================================================================
> > http://busybox.net/bugs/view.php?id=405
> > ======================================================================
> > Summary:                    [PATCH] nfs mount and options are broken in
> > svn Description:
> > nfs mounting and probably more is broken after the last mount.c changes.
> >
> > 1. parse_mount_options() is not adding options to string_flags correctly.

I don't have an nfs server to test against.  Could somebody give me a little 
more info about what "not correctly" is here?  (Give me a command line that 
doesn't work, and what you'd like string_flags to contain in that case...)

> > 2. nfs has to `goto mount_it_now` when nfsmount return sucessfully,
> > otherwise no mount happens.

You mean inserting that line right after fsType="nfs"; (currently line 288)?  
Easy enough, but not worth checking in without the other half of the fix...

> care to take care of this Rob ? :)

Sure.

Rob