[BusyBox] [patch] get_terminal_width_height() return value

Rob Landley rob at landley.net
Wed Aug 24 00:45:39 UTC 2005

On Tuesday 23 August 2005 16:55, Bernhard Fischer wrote:
> Hi,
> attached patch makes libbb's get_terminal_width_height() return the
> result of the ioctl. This is useful to check if the FD was e.g. a tty
> (or not) etc.
> I do not know if the preferred way of dealing with such a change is to
> change get_terminal_width_height from void to int in general instead of
> conditionally.
> Please apply or let me know if you'd be willing to checkin a variant
> which changes said function to return an int unconditionally.
> Thank you,
> Bernhard

I'd prefer unconditionally, myself.  What's the size difference?


More information about the busybox mailing list