[BusyBox] [PATCH] ASH's read bugs

Paul Fox pgf at brightstareng.com
Fri Aug 12 12:10:24 UTC 2005

 > As I'm seeing patches beeing submited in the maillist, I'm posting this
 > patch both here and in the bug report site. Here follows the
 > description:

fernando -- thanks for the patch.  i've addressed some (but i think not
all) of the things you've found in the patch attached to bug 242, which
hasn't yet been applied to the svn tree.  could you look at this patch:
and see what you think?  it sounds like you noticed some problems
with the old code that i did not, and therefore, i might not have
fixed them.  i'll compare what you've done and try to merge them
before applying either one.


 > There is some bugs in ASH's read. I've fixed those that I found and
 > added a new feature. Here they are:
 > - Timeout:
 >   - The timeout option counts only the first char: it will stop counting
 >     the time after you press the first key;
 >   - When the timeout option is used, the first char cannot be erased and
 >     is handled wrongly if it is a backslash and/or with IFS environment
 >     variable;
 >   - Some special characters, when in the first field, cannot be shown or
 >     are treated wrong;
 >   - The exit code is wrong and the environment variable is empty when
 >     the timeout is expired;
 > - Silent:
 >   - I added a `silent' feature: when the -s argument is provided, the
 >     characters are not echoed;
 > The comparisons I made was using `bash' and `zsh'. The patch is
 > attached.
 > --
 > Fernando Silveira <fsilveira at gmail.com>

 paul fox, pgf at brightstareng.com

More information about the busybox mailing list