[BusyBox] Re: busybox-cvs Digest, Vol 25, Issue 8

[Mike Frysinger]

On Monday 18 April 2005 04:20 am, Vladimir N. Oleynik wrote:
> please add "static"
> > +struct {
> > +} conns[MAXCONNS];
>
> and too
> > +struct {
> > +} G;

done

> this 8 lines
> > +	while ((flag = getopt(argc, argv, "b:")) != EOF) {
> > +		switch (flag) {
> > +		case 'b':
> > +			bind_ip_address = optarg;
> > +			break;
> > +		default:
> > +			bb_show_usage();
> > +		}
>
> is equivalent one line
>
> 	bb_getopt_ulflags(argc, argv, "b:", &bind_ip_address);

i tried looking at bb_getopt as a replacement but the code was a bit hard to 
understand and ive never used it before so i gave up

thanks, added this change too :)

> > +	while (1) {
> > +	fd_set rfds = G.readfds;
>
> strange indent formating

it is a little strange, but since that while() loop is never broken, indenting 
all the rest of the main func 1 block seemed like a waste of whitespace ... 
i'll add a comment that says 'this is the main while loop and we never exit 
it' so people are more likely to get the hint :)
-mike