[BusyBox] Re: busybox-cvs Digest, Vol 25, Issue 8

[Vladimir N. Oleynik]

Thomas,

> Added: trunk/busybox/networking/fakeidentd.c

please add "static"

> +struct {
> +	char buf[20];
> +	int len;
> +	time_t lasttime;
> +} conns[MAXCONNS];

and too

> +/* When using global variables, bind those at least to a structure. */
> +struct {
> +	const char *identuser;
> +	fd_set readfds;
> +	int conncnt;
> +} G;

this 8 lines

> +	while ((flag = getopt(argc, argv, "b:")) != EOF) {
> +		switch (flag) {
> +		case 'b':
> +			bind_ip_address = optarg;
> +			break;
> +		default:
> +			bb_show_usage();
> +		}

is equivalent one line

	bb_getopt_ulflags(argc, argv, "b:", &bind_ip_address);

> +	while (1) {
> +	fd_set rfds = G.readfds;

strange indent formating

--w
vodz