[BusyBox] [PATCH] sed 'T' command

Rob Landley rob at landley.net
Tue Apr 12 21:58:21 UTC 2005


On Tuesday 12 April 2005 01:41 pm, Colin Watson wrote:
> This patch implements the 'T' command in sed. This is a GNU extension,
> but one of the udev hotplug scripts uses it, so I need it in busybox
> anyway.
>
> Includes a test; 'svn add testsuite/sed/sed-branch-conditional-inverted'
> after applying.
>
> Thanks,

<rummages in box for busybox sed maintainer hat, can't find hat, balances 
sushi pillow on head on general principles>

Looks good, but if you're going to add a new option, please update 
"include/usage.h".

(I assume the optimizer's smart enough to turn if(a) {if(b) break; else if(c) 
break;} into if(a ? b : c) break, and that people other than me find the more 
verbose form more readable, so I won't quibble about style...)

With the usage updated, I'm happy with the patch.  Eric's probably going to 
want it stuck into his bug tracker before he'll apply it, though.  
(http://bugs.busybox.net I believe).

</sushi pillow falls off head>

Rob



More information about the busybox mailing list