[BusyBox] [patch] auto width

Erik Andersen andersen at codepoet.org
Tue Mar 23 23:25:40 UTC 2004


On Tue Mar 23, 2004 at 01:46:45PM -0800, Brian Pomerantz wrote:
> I've noticed a bug in the "autowidth" feature more, and is probably in
> others.  The call to the function get_terminal_width_height() passes
> in a file descriptor but that file descriptor is never used, instead
> the ioctl() is called with 0.  In more_main() the call to
> get_terminal_width_height() passes 0 as the file descriptor instead of
> fileno(cin).  This isn't a problem when you more a file (e.g. "more
> /etc/passwd") but when you pipe a file to it (e.g. "cat /etc/passwd |
> more") the size of the terminal cannot be determined because file
> descriptor 0 is not a terminal.  The fix is simple, I've attached a
> patch for more.c and get_terminal_width_height.c.

Applied thanks,

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--



More information about the busybox mailing list