[BusyBox] hdparm cmdline parsing

Erik Andersen andersen at codepoet.org
Sat Mar 20 00:58:55 UTC 2004


On Fri Mar 19, 2004 at 02:55:04PM +0000, Tito wrote:
> > Thanks for the great bug report!  Fixed now in cvs,
> > 
> Hi to all,
> sorry for this bug, I don't tested it enough :-(.

No problem.  Glad we got it fixed now though.  :-)

> BTW, printf at line 2839 should be a bb_error_msg.
> 2838						if (!set_apmmode)
> 2839							printf("-B: %s (1-255)", bb_msg_missing_value);
> 2840						break;

Thanks, done.

I think we could probably restore much of the hdparm size
optimizations.  Premature optimization and all that.  If we were
to make p, argc, and argv globals we could actually improve upon
the size optimization that was done previously and could probably
save at least 512 bytes.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--



More information about the busybox mailing list