[BusyBox] Re: busybox-cvs Digest, Vol 10, Issue 14

[Glenn McGrath]

On Mon, 19 Jan 2004 12:38:06 +0300
"Vladimir N. Oleynik" <dzo at simtreas.ru> wrote:

> Its bad ideas.
> Your make dynamic memory allocation (but not require) from daemon
> with exiting after error and make memory leak after sighup signaled
> and reread config.

hmm, i didnt see that memory leak, but that section of code isnt needed,
inetd.conf arguments should only be seperated by spaces or tabs, not
spread over multiple lines.

skip() also has extra checks that arent needed.

newstr() can be replaced by bb_xstrdup, only disadvantage is that "out
of memory" error message gets lost.

I think the inetd.conf parsing can improved further, attached is what i
have so far.



Glenn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inetd.diff
Type: application/octet-stream
Size: 3263 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20040119/5cf9fba8/attachment.obj