[BusyBox] Another issue/bug in tftp.c

Erik Andersen andersen at codepoet.org
Sat Jul 26 08:16:38 UTC 2003


On Mon Jul 21, 2003 at 05:17:19PM +0200, Christian Meyer wrote:
> The client gives up way too soon because timeout is set to 0 (line 332 as mentioned before).
> 
> There's a solution for that problem:
> 
> --- tftp.c     Fri Jul 18 16:40:10 2003
> +++ tftp.c     Mon Jul 21 16:10:23 2003
> @@ -288,7 +288,8 @@
> 
>                 /* send packet */
> 
> -
> +               timeout = bb_tftp_num_retries;  /* re-initialize */
> +
>                 do {
> 
>                         len = cp - buf;
> 
> The timeout is set before the do ... while loop and thus it should solve the problem.

This looks like a fine fix.  Applied,

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--



More information about the busybox mailing list