[BusyBox] TAKE 2: Message on Startup: "sh: can't access tty; job control turned off"

[Vladimir N. Oleynik]

Stewart,

> The tests around the code that emits that message is rather strange
> (shell/ash.c; revision 1.66; line 5994).  It goes:
> 
>   initialpgrp = tcgetpgrp(2);
>   if (initialpgrp < 0) { ...; return; }
>   if (initialpgrp == -1) ....
> 
> so the second test can never succeed.  I'm no expert when it comes to process
> group things though, so I don't know what the right thing to do here is, or
> indeed whether the code does behave correctly and the extra condition is
> simply harmless.

Thanks. You found original ash strange code. 
Current dash shell have this code better.
Patch attached.
But, "job control turned off" problem not solved - previous code
have one iteration do while() loop.
Current busybox have this problen only for serial console usage
without getty/openvt(real, not bb). 
Kernel don`t set CTTY automaticaly for open(serail_console).


--w
vodz