[BusyBox] ash (busybox) problem:"job control turned off" -- getty (tinylogin) problem: errno25: Not a typewriter (printed as "Inappropriate ioctl for device")

[Vladimir N. Oleynik]

Erik,

> > > Hi vodz.  Your login patch looks fine to me.  I don't
> > > see any patch to init.c though.  Forgotten?
> >
> > Ok. I ready for publicate this path.
> >
> > Comment special for others patcher`s:
> >
> > 1) PLEASE. Do not change strlen("strings") to sizeof("string").
> > This not equivalent! (align effect).
> > I very long time finding this strange error... :(
> >
> > 2) Function console_setup() closed descriptor! (Very old bug).
> >
> > 3) Please not put setsid() in mixed places. This do different effect!
> 
> Thanks again vodz, very nice work.  Applied!

Thanks.
I have missed one more strange editing:
ioctl(tmp_pid, TIOCSCTTY, 1);
Also, I like not my humour patch safe_strcpy->snprintf ;)
buffer may be set not.
Also, founded spare code "tmpCmd++;"

> > 4) I think, ASK_FIRST set emergency shell mode. This not have
> > by default "job control".
> 
> I think it is best for the askfirst init actions to get a
> controlling tty.  So I made a minor change to let that happen.
> I've spent some time testing this and it seems to be working
> nicely now.  Maybe slackware can now drop their noisereduction
> patch.  ;-)

Heroically we overcome ambiguity. Well, it is possible and so. ;)


--w
vodz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: last_patch48.gz
Type: application/x-gzip
Size: 1813 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20020703/bb0a2112/attachment.bin