bug#1129: [BusyBox] bug#1129: sync.c does not compile on RedHat 7.1

[Mark Whitley]

On Tue, Mar 13, 2001 at 05:39:51PM +0100, Gratien D'haese (Hewlett-Packard) wrote:
> 
> I'm the maintainer of mkCDrec and one of my beta-tester on RedHat 7.1
> reported a bug against busybox' sync.c.
> On RedHat 7.1 gcc-2.96-75 is used as c compiler. The following makes
> sync.c compile properly
> 
> --- sync.c.orig Mon Mar   5 17:44:42 2001
> +++ sync.c      Sun Mar   4 17:34:14 2001
> @@ -29,5 +29,7 @@
>  {
> 	if (argc > 1 && **(argv + 1) == '-')
> 		usage(sync_usage);
> -	return(sync());
> +/*	return(sync());*/
> +	sync();
> +	return(0);
>  }
> 
> According to man 2 sync, the prototype for sync is:
> extern void sync(void)
> 
> Hope this fix is good enough?


Gratien, It looks like the code you are working with is a little out of date.
The current implementation of sync.c looks like this:

	extern int sync_main(int argc, char **argv)
	{
		if (argc > 1 && **(argv + 1) == '-')
			show_usage();
		sync();
		return(EXIT_SUCCESS);
	}

A change was committed on 2001/02/16 that took sync() out of the call to
return. It should work fine now.

We are about to release an 0.50 version of busybox that contains this fix. If
you'd like, you can check out the code that's in CVS right now and give it a
go.

I will close this bug.


Mark Whitley
markw at lineo.com