[BusyBox] bug#1117: Correct my stty in recovery_mode
Vladimir N. Oleynik
dzo at simtreas.ru
Thu Mar 8 19:34:45 UTC 2001
Mark Whitley wrote:
> > So yours changes without consultation of the author real substantiations have my
> > discontent under themselves.
>
> This is a collaborative effort. People make changes to the stuff I write, too,
> sometimes without consultation. It happens. By and large, though, changes
> that get in are for the better (we hope). If there's a problem with a change
> somebody else made, you're welcome to mention it. If there isn't a problem,
> try not to let it bother you.
Completely my initial texts: cmdedit.c and stty.c were missed through automatic
formator
though it was specified, that in CVS my variant is placed.
What to me was to see, when I was going to send changes with additional
opportunities to
these texts, that my new variant at all does not give any reasonable diff.
> Here's another approach you could try that doesn't involve using any #define
> TEST constructs and eliminates the need to re-define functions used in
> utility.c: Comment out of Config.h everything except the applet you want to
> test and then compile it (this is what the multibuild.pl script does). You'll
> end up with a busybox that has one (and only one) applet in it that you can
> test to your heart's content.
Really you do not see under messages in it maillist, what they are based at all
on the
freshest version in CVS, and on release?
I too have no opportunity to use yours CVS as to receive full variant through
yours
http-CVS monstrously inconveniently.
All my works always will be carried out _only_ on standalone modules.
(cmdedit, stty have this code. My fresh patch to tftp.c I generate _after_
addition
standalone source and put this variant mantiner this code in personal email).
> This is a seperate issue but one worth consideration. We haven't spent too
> much effort on things like internationalization because there have been bigger
> issues to deal with. Perhaps it's time to give i18n a little more attention,
> and bindtextdomain() is certainly one approach that could be used. If you
> could show us some code that implements this, that would be even more helpful.
Here it is not necessary to think out anything.
Look at an original code for example util-linux-*v/lib/nls.h
#ifdef ENABLE_NLS
# include <libintl.h>
# define _(Text) gettext (Text)
# ifdef gettext_noop
# define N_(String) gettext_noop (String)
# else
# define N_(String) (String)
# endif
#else
# undef bindtextdomain
# define bindtextdomain(Domain, Directory) /* empty */
# undef textdomain
# define textdomain(Domain) /* empty */
# define _(Text) (Text)
# define N_(Text) (Text)
#endif
Full tested ready metod.
I think, following my work with uclibc after commit my realization LC_CTYPE will
be above
bintextdomain() ;)
> > 4) The new patch to (show_)usage() is made in view of strong optimization on
> > the size. ( Remember old dispute about bsearch? ;)) )
> > Well. But let's make an opportunity of everyone applet to have an opportunity to
> > comprise text of the "Usage: bla-bla", and file for all applet usage_msgs
> > to generate with programm.
>
> I'm afraid I don't follow what you're saying here. Are you proposing moving
> usage messages into messages.c? Are you proposing moving usage messages back
> into the applet.c files and have the usage.h file auto-generated?
Yes. Last.
--w
vodz
More information about the busybox
mailing list