[BusyBox] Patch with clean and remove bugs to m* utils
Vladimir N. Oleynik
dzo at simtreas.ru
Wed Jan 31 18:11:44 UTC 2001
Erik Andersen wrote:
> On Mon Jan 29, 2001 at 12:27:27PM +0300, Vladimir N. Oleynik wrote:
> > Patch in attach include
> > - mkdir: remove 3 lines in source code. Status: low
> > - mkfs_minix: save 32 bytes, remove 4 bugs. Status: require.
> > - mkswap: save 64 bytes, remove 1 bug. Status: require.
>
> Excellent work. Applied.
Thanks.
> As I was looking over your patch, I began thinking about
> how often error_msg_and_die() and error_msg() are used.
> Right now, these functions require a terminating \n.
> These functions are used a _lot_ so we could save some
> space by putting the \n into error_msg_and_die() and error_msg().
>
> $ grep error_msg *.c | grep -v perror_msg |wc
> 346 2064 21721
Hmm, It my idea ~ 10 December: my first post in this maillist! :00
> --- utility.c 2001/01/30 18:03:11 1.194
> +++ utility.c 2001/01/31 17:45:07
> @@ -105,6 +105,7 @@ extern void error_msg(const char *s, ...
> va_start(p, s);
> verror_msg(s, p);
> va_end(p);
> + write(fileno(stderr), "\n", 1);
putc('\n', stderr) not best? ;00
--w
vodz
More information about the busybox
mailing list