[BusyBox] interesing my ideas?!
Larry Doolittle
ldoolitt at recycle.lbl.gov
Wed Jan 10 20:46:56 UTC 2001
I looked at Vladimir's patch. Most of it is clearly an improvement.
1. Pulling search_applet() out as a seperate routine is good,
but I think it belongs in utility.c, and should use the bsearch()
method that busybox.c and sh.c use now. If you measure that the
linear search really has smaller code size compared to bsearch,
and you really care about the difference, put in a compile-time
option, so people have the choice of big-fast and small-slow.
2. Encapsulating access to the name and directory of applets is good,
but the modern way to do that is with inline functions instead of
macros.
3. Making the applet size determination numeric instead of null-terminated
is OK. You'd have to make a careful comparison of object size on a couple
of targets to see which way actually gives you smaller code.
4. I don't think I understand the motivation, or consequences, of your
change to error handling in busybox --install.
5. Pulling the path code into the name stream is weird, but clearly
effective. Once the other non-weird changes are in, this is actually
a very small change, that could be backed out if people didn't like it.
- Larry
More information about the busybox
mailing list