insmod symbol export broken with old kernels

Larry Doolittle ldoolitt at recycle.lbl.gov
Thu Jan 4 00:35:32 UTC 2001


Package: busybox
Version: 0.48 and current CVS
Severity: normal

This one-liner un-breaks a change made between 0.47 and 0.48.
The failure mode shows up as corrupted symbol exports when
using "BB_FEATURE_INSMOD_OLD_KERNEL".

Please apply to the CVS copy.

      - Larry

--- /home/ldoolitt/cvs/busybox/insmod.c	Tue Jan  2 09:15:53 2001
+++ insmod.c	Wed Jan  3 16:29:48 2001
@@ -1704,7 +1704,8 @@
 						ksym->name =
 							(unsigned long) str - (unsigned long) symtab;
 
-						str = strcpy(str, sym->name) + 1;
+						/* maybe stpcpy is not universal? */
+						str = strcpy(str, sym->name) + strlen(sym->name) + 1;
 						ksym++;
 					}
 			}

---------------------------------------
Received: (at 1088-done) by bugs.lineo.com; 4 Jan 2001 02:00:47 +0000


More information about the busybox mailing list