[git commit] wget: ignore header casing

Denys Vlasenko vda.linux at googlemail.com
Mon Jul 8 13:02:58 UTC 2024


commit: https://git.busybox.net/busybox/commit/?id=9f262698cc7e6a8b5621f018645f3c1fa06b226f
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

HTTP headers are case insensitive and therefore the check if a default
header has been overwritten needs to be case insensitive.

Without this patch `--header 'user-agent: test'` results in
`User-Agent: Wget` and `user-agent: test` being send.

function                                             old     new   delta
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0)                 Total: 0 bytes
   text	  data	   bss	   dec	   hex	filename
1040876	 16443	  1840	1059159	102957	busybox_old
1040876	 16443	  1840	1059159	102957	busybox_unstripped

Signed-off-by: Sertonix <sertonix at posteo.net>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/wget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/wget.c b/networking/wget.c
index 199ddd4da..512bebfc2 100644
--- a/networking/wget.c
+++ b/networking/wget.c
@@ -1602,7 +1602,7 @@ IF_DESKTOP(	"no-parent\0"        No_argument       "\xf0")
 			bit = 1;
 			words = wget_user_headers;
 			while (*words) {
-				if (strstr(hdr, words) == hdr) {
+				if (strcasestr(hdr, words) == hdr) {
 					G.user_headers |= bit;
 					break;
 				}


More information about the busybox-cvs mailing list