[git commit] unzip: document some options we might support

Denys Vlasenko vda.linux at googlemail.com
Thu Feb 23 11:00:36 UTC 2023


commit: https://git.busybox.net/busybox/commit/?id=029740a3e43835d2a71696449baba5250a346e0a
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 archival/unzip.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/archival/unzip.c b/archival/unzip.c
index 691a2d81b..71a302915 100644
--- a/archival/unzip.c
+++ b/archival/unzip.c
@@ -559,6 +559,11 @@ int unzip_main(int argc, char **argv)
  *    204372                   1 file
  */
 
+//TODO: accept and ignore these?
+// -a	convert to text files with 't' label, -aa: all files
+// -b	do not convert to text - bbox: we don't convert anything
+// -D	skip restoration of timestamps for extracted items - bbox: we don't restore these (yet?)
+// -X	restore user:group ownership
 	opts = 0;
 	/* '-' makes getopt return 1 for non-options */
 	while ((i = getopt(argc, argv, "-d:lnotpqxjvK")) != -1) {
@@ -583,6 +588,7 @@ int unzip_main(int argc, char **argv)
 			xmove_fd(xopen("/dev/null", O_WRONLY), STDOUT_FILENO);
 			/*fallthrough*/
 
+// NB: -c extract files to stdout/screen (unlike -p, also prints .zip and file names to stdout)
 		case 'p': /* Extract files to stdout */
 			dst_fd = STDOUT_FILENO;
 			/*fallthrough*/
@@ -853,6 +859,7 @@ int unzip_main(int argc, char **argv)
 		unzip_skip(zip.fmt.extra_len);
 
 		/* Guard against "/abspath", "/../" and similar attacks */
+// NB: UnZip 6.00 has option -: to disable this
 		overlapping_strcpy(dst_fn, strip_unsafe_prefix(dst_fn));
 
 		/* Filter zip entries */


More information about the busybox-cvs mailing list