[git commit] vi: trivial code shrink

Denys Vlasenko vda.linux at googlemail.com
Sat May 1 12:00:09 UTC 2021


commit: https://git.busybox.net/busybox/commit/?id=74e1f321c147753573e4b6bcd34e98708b5ece52
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
get_input_line                                       178     176      -2

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 editors/vi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/editors/vi.c b/editors/vi.c
index edcf84240..99babccbb 100644
--- a/editors/vi.c
+++ b/editors/vi.c
@@ -1200,7 +1200,7 @@ static char *get_input_line(const char *prompt)
 	strcpy(buf, prompt);
 	last_status_cksum = 0;	// force status update
 	go_bottom_and_clear_to_eol();
-	write1(prompt);      // write out the :, /, or ? prompt
+	write1(buf);      // write out the :, /, or ? prompt
 
 	i = strlen(buf);
 	while (i < MAX_INPUT_LEN - 1) {
@@ -1209,8 +1209,8 @@ static char *get_input_line(const char *prompt)
 			break;		// this is end of input
 		if (c == term_orig.c_cc[VERASE] || c == 8 || c == 127) {
 			// user wants to erase prev char
-			buf[--i] = '\0';
 			write1("\b \b"); // erase char on screen
+			buf[--i] = '\0';
 			if (i <= 0) // user backs up before b-o-l, exit
 				break;
 		} else if (c > 0 && c < 256) { // exclude Unicode


More information about the busybox-cvs mailing list