[git commit] shred: with -u, unlink file even if it is zero length

Denys Vlasenko vda.linux at googlemail.com
Sun Jun 20 11:48:21 UTC 2021


commit: https://git.busybox.net/busybox/commit/?id=d71c7892ac56939cfcf3fa699ee8b0195631ee5a
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
shred_main                                           391     387      -4

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 coreutils/shred.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/coreutils/shred.c b/coreutils/shred.c
index 4b95d197c..04bf87229 100644
--- a/coreutils/shred.c
+++ b/coreutils/shred.c
@@ -99,12 +99,12 @@ int shred_main(int argc UNUSED_PARAM, char **argv)
 				bb_copyfd_size(zero_fd, fd, size);
 				fdatasync(fd);
 			}
-			if (opt & OPT_u) {
-				ftruncate(fd, 0);
-				xunlink(fname);
-			}
-			xclose(fd);
 		}
+		if (opt & OPT_u) {
+			ftruncate(fd, 0);
+			xunlink(fname);
+		}
+		xclose(fd);
 	}
 
 	return EXIT_SUCCESS;


More information about the busybox-cvs mailing list