[git commit] base32/64: accept -i "skip bad chars" option (currently in effect unconditionally)

Denys Vlasenko vda.linux at googlemail.com
Sun Jun 13 21:58:17 UTC 2021


commit: https://git.busybox.net/busybox/commit/?id=643b308029ac42f466fa17e4ff400e47003205d9
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
.rodata                                           103189  103190      +1

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 coreutils/uudecode.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/coreutils/uudecode.c b/coreutils/uudecode.c
index bd7766ef7..a607977e9 100644
--- a/coreutils/uudecode.c
+++ b/coreutils/uudecode.c
@@ -194,7 +194,9 @@ int uudecode_main(int argc UNUSED_PARAM, char **argv)
 //usage:       "Base64 encode or decode FILE to standard output\n"
 //usage:     "\n	-d	Decode data"
 //usage:     "\n	-w COL	Wrap lines at COL (default 76, 0 disables)"
-////usage:     "\n	-i	When decoding, ignore non-alphabet characters"
+///////:     "\n	-i	When decoding, ignore non-alphabet characters"
+// -i is accepted but has no effect: currently, decode_base32/64() functions
+// (called via read_base64()) skip invalid chars unconditionally.
 
 //                 APPLET_ODDNAME:name    main     location    suid_type     help
 //applet:IF_BASE32(APPLET_ODDNAME(base32, baseNUM, BB_DIR_BIN, BB_SUID_DROP, base32))
@@ -272,7 +274,7 @@ int baseNUM_main(int argc UNUSED_PARAM, char **argv)
 	unsigned opts;
 	unsigned col = 76;
 
-	opts = getopt32(argv, "^" "dw:+" "\0" "?1"/* 1 arg max*/, &col);
+	opts = getopt32(argv, "^" "diw:+" "\0" "?1"/* 1 arg max*/, &col);
 	argv += optind;
 
 	if (!argv[0])


More information about the busybox-cvs mailing list