[git commit] echo: add FIXME comment

Denys Vlasenko vda.linux at googlemail.com
Wed Dec 29 06:26:23 UTC 2021


commit: https://git.busybox.net/busybox/commit/?id=0e2cb6d1e2553675bba2999829bbc29219aea987
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 coreutils/echo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/coreutils/echo.c b/coreutils/echo.c
index 82f0358b6..44b2eb5d0 100644
--- a/coreutils/echo.c
+++ b/coreutils/echo.c
@@ -321,6 +321,8 @@ int echo_main(int argc, char **argv)
 				if (*arg == '0' && (unsigned char)(arg[1] - '0') < 8) {
 					arg++;
 				}
+//FIXME? we also accept non-0 starting sequences (see echo-prints-slash_41 test)
+// echo -ne '-\41-' prints "-!-". bash 5.0.17 does not (prints "-\41-").
 				/* bb_process_escape_sequence can handle nul correctly */
 				c = bb_process_escape_sequence( (void*) &arg);
 			}


More information about the busybox-cvs mailing list