[Bug 12646] New: dhcpc.c not using discover_retries in REQUESTING state

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=12646

            Bug ID: 12646
           Summary: dhcpc.c not using discover_retries in REQUESTING state
           Product: Busybox
           Version: 1.31.x
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Networking
          Assignee: unassigned at busybox.net
          Reporter: john.lange2 at t-mobile.com
                CC: busybox-cvs at busybox.net
  Target Milestone: ---

dhcpc.c is not using discover_retries while in REQUESTING state. The code
assumes a value of 3. Instead, it should use the -t parameter provided on
command line. The following diff could address this issue:
1505c1505
<                               if (packet_num < 3) {
---
>                               if (!discover_retries || packet_num <= discover_retries) {

Note "<=" is used so that discover_retries value of 1 will work, since
packet_num is also incremented within state INIT_SELECTING.

-- 
You are receiving this mail because:
You are on the CC list for the bug.