[git commit] login: log to syslog every bad password, not only 3rd

Denys Vlasenko vda.linux at googlemail.com
Wed Dec 2 16:47:16 UTC 2020


commit: https://git.busybox.net/busybox/commit/?id=50ead33c45919abffde35313daac4c2dfd8641ca
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 loginutils/login.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/loginutils/login.c b/loginutils/login.c
index c3a835180..f0bce50ce 100644
--- a/loginutils/login.c
+++ b/loginutils/login.c
@@ -508,13 +508,11 @@ int login_main(int argc UNUSED_PARAM, char **argv)
 		pause_after_failed_login();
 		/* TODO: doesn't sound like correct English phrase to me */
 		puts("Login incorrect");
+		syslog(LOG_WARNING, "invalid password for '%s'%s",
+					username, fromhost);
 		if (++count == 3) {
-			syslog(LOG_WARNING, "invalid password for '%s'%s",
-						username, fromhost);
-
 			if (ENABLE_FEATURE_CLEAN_UP)
 				free(fromhost);
-
 			return EXIT_FAILURE;
 		}
 		username[0] = '\0';


More information about the busybox-cvs mailing list