[git commit] ash: add a FIXME comment

Denys Vlasenko vda.linux at googlemail.com
Thu Sep 5 12:31:49 UTC 2019


commit: https://git.busybox.net/busybox/commit/?id=35e349de3c93ab75abd8a990aaa1e01658273650
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/shell/ash.c b/shell/ash.c
index 305fb6348..c5588ea66 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -12393,7 +12393,13 @@ checkend: {
 		for (p = eofmark; STPUTC(c, out), *p; p++) {
 			if (c != *p)
 				goto more_heredoc;
-
+			/* FIXME: fails for backslash-newlined terminator:
+			 * cat <<EOF
+			 * ...
+			 * EO\
+			 * F
+			 * (see heredoc_bkslash_newline2.tests)
+			 */
 			c = pgetc_without_PEOA();
 		}
 


More information about the busybox-cvs mailing list