[Bug 12296] pidof fails to find tasks with names 15 characters long

bugzilla at busybox.net bugzilla at busybox.net
Fri Nov 1 13:24:52 UTC 2019


https://bugs.busybox.net/show_bug.cgi?id=12296

--- Comment #3 from Denys Vlasenko <vda.linux at googlemail.com> ---
(In reply to Alin Nastac from comment #2)
> What do you think is more important?
> a) 0.0001% chance of having a false positive

Certainly this one: people will get mad when they would kill an unrelated
process. What excuse would you propose I can use for doing that?

BTW.

> When argv0 support is not compiled in

...which should not be possible:

        PSSCAN_ARGVN    = (1 << 16) * (ENABLE_KILLALL
                                || ENABLE_PGREP || ENABLE_PKILL
                                || ENABLE_PIDOF
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                || ENABLE_SESTATUS

Can you debug why this part:

                /* or we require argv0 to match (essential for matching
reexeced /proc/self/exe)*/
                 || (p->argv0 && strcmp(bb_basename(p->argv0), procName) == 0)

does not work in your case?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the busybox-cvs mailing list