[git commit] dhcp: downgrade "got raw socket fd" message to log3, make log2 default max

Denys Vlasenko vda.linux at googlemail.com
Fri May 31 21:52:16 UTC 2019


commit: https://git.busybox.net/busybox/commit/?id=6eb6e6a1e9d6e7d4dd154014ce404ec1c8175fb2
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

log3 messages are very much redundant

function                                             old     new   delta
change_listen_mode                                   322     302     -20

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/udhcp/Config.src | 2 +-
 networking/udhcp/d6_dhcpc.c | 2 +-
 networking/udhcp/dhcpc.c    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/networking/udhcp/Config.src b/networking/udhcp/Config.src
index f16fc0a4f..8ef24748e 100644
--- a/networking/udhcp/Config.src
+++ b/networking/udhcp/Config.src
@@ -116,7 +116,7 @@ config FEATURE_UDHCP_PORT
 
 config UDHCP_DEBUG
 	int "Maximum verbosity level (0..9)"
-	default 9
+	default 2
 	range 0 9
 	depends on UDHCPD || UDHCPC || UDHCPC6 || DHCPRELAY
 	help
diff --git a/networking/udhcp/d6_dhcpc.c b/networking/udhcp/d6_dhcpc.c
index 02766ba16..422b88882 100644
--- a/networking/udhcp/d6_dhcpc.c
+++ b/networking/udhcp/d6_dhcpc.c
@@ -981,7 +981,7 @@ static int d6_raw_socket(int ifindex)
 	log2("opening raw socket on ifindex %d", ifindex);
 
 	fd = xsocket(PF_PACKET, SOCK_DGRAM, htons(ETH_P_IPV6));
-	log2("got raw socket fd %d", fd);
+	log3("got raw socket fd %d", fd);
 
 	memset(&sock, 0, sizeof(sock)); /* let's be deterministic */
 	sock.sll_family = AF_PACKET;
diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c
index f040e93f7..739870bee 100644
--- a/networking/udhcp/dhcpc.c
+++ b/networking/udhcp/dhcpc.c
@@ -1017,7 +1017,7 @@ static int udhcp_raw_socket(int ifindex)
 	 * SOCK_DGRAM: remove link-layer headers on input (SOCK_RAW keeps them)
 	 * ETH_P_IP: want to receive only packets with IPv4 eth type
 	 */
-	log2("got raw socket fd");
+	log3("got raw socket fd %d", fd);
 
 	memset(&sock, 0, sizeof(sock)); /* let's be deterministic */
 	sock.sll_family = AF_PACKET;


More information about the busybox-cvs mailing list