[git commit] cal: make it NOEXEC

Denys Vlasenko vda.linux at googlemail.com
Sun Jan 14 13:32:11 UTC 2018


commit: https://git.busybox.net/busybox/commit/?id=cbdc37cae079d6b52ca39fb6c1dd6eadab48b617
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 NOFORK_NOEXEC.lst | 2 +-
 util-linux/cal.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/NOFORK_NOEXEC.lst b/NOFORK_NOEXEC.lst
index 72c33dd..21a3b41 100644
--- a/NOFORK_NOEXEC.lst
+++ b/NOFORK_NOEXEC.lst
@@ -72,7 +72,7 @@ brctl - noexec
 bunzip2 - runner
 bzcat - runner
 bzip2 - runner
-cal - runner: cal -n9999
+cal - noexec. can be runner: cal -n9999
 cat - runner: cat HUGEFILE
 chat - longterm (when used as intended - talking to modem over stdin/out)
 chattr - noexec. runner
diff --git a/util-linux/cal.c b/util-linux/cal.c
index 10df0ae..a4a20d5 100644
--- a/util-linux/cal.c
+++ b/util-linux/cal.c
@@ -16,7 +16,8 @@
 //config:	help
 //config:	cal is used to display a monthly calendar.
 
-//applet:IF_CAL(APPLET(cal, BB_DIR_USR_BIN, BB_SUID_DROP))
+//applet:IF_CAL(APPLET_NOEXEC(cal, cal, BB_DIR_USR_BIN, BB_SUID_DROP, cal))
+/* NOEXEC despite rare cases when it can be a "runner" (e.g. cal -n12000 takes you into years 30xx) */
 
 //kbuild:lib-$(CONFIG_CAL) += cal.o
 


More information about the busybox-cvs mailing list