[git commit] shell: echo ${?:0} was fixed sometime ago, enable it in tests

Denys Vlasenko vda.linux at googlemail.com
Sat Jan 13 18:28:19 UTC 2018


commit: https://git.busybox.net/busybox/commit/?id=aea52e7b2d8a44e1c84575f5a83b36126a07ef6b
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash_test/ash-vars/param_expand_bash_substring.right   | 1 +
 shell/ash_test/ash-vars/param_expand_bash_substring.tests   | 2 +-
 shell/hush_test/hush-vars/param_expand_bash_substring.right | 1 +
 shell/hush_test/hush-vars/param_expand_bash_substring.tests | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/shell/ash_test/ash-vars/param_expand_bash_substring.right b/shell/ash_test/ash-vars/param_expand_bash_substring.right
index 9ad6dbc..687dd90 100644
--- a/shell/ash_test/ash-vars/param_expand_bash_substring.right
+++ b/shell/ash_test/ash-vars/param_expand_bash_substring.right
@@ -3,6 +3,7 @@ SHELL: line 1: syntax error: bad substitution
 SHELL: line 1: syntax error: bad substitution
 SHELL: line 1: syntax error: bad substitution
 SHELL: line 1: syntax error: missing '}'
+0
 1    =||
 1:1  =||
 1:1:2=||
diff --git a/shell/ash_test/ash-vars/param_expand_bash_substring.tests b/shell/ash_test/ash-vars/param_expand_bash_substring.tests
index cce9f12..512da35 100755
--- a/shell/ash_test/ash-vars/param_expand_bash_substring.tests
+++ b/shell/ash_test/ash-vars/param_expand_bash_substring.tests
@@ -11,7 +11,7 @@ export var=0123456789
 "$THIS_SH" -c 'echo ${var:}' SHELL
 
 # then some funky ones
-# UNFIXED BUG: this should work: "$THIS_SH" -c 'echo ${?:0}'
+"$THIS_SH" -c 'echo ${?:0}' SHELL
 
 # now some valid ones
 set --; echo "1    =|${1}|"
diff --git a/shell/hush_test/hush-vars/param_expand_bash_substring.right b/shell/hush_test/hush-vars/param_expand_bash_substring.right
index 2f4c51d..a3cb549 100644
--- a/shell/hush_test/hush-vars/param_expand_bash_substring.right
+++ b/shell/hush_test/hush-vars/param_expand_bash_substring.right
@@ -3,6 +3,7 @@ hush: syntax error: unterminated ${name}
 hush: syntax error: unterminated ${name}
 hush: syntax error: unterminated ${name}
 0123456789
+0
 1    =||
 1:1  =||
 1:1:2=||
diff --git a/shell/hush_test/hush-vars/param_expand_bash_substring.tests b/shell/hush_test/hush-vars/param_expand_bash_substring.tests
index cce9f12..512da35 100755
--- a/shell/hush_test/hush-vars/param_expand_bash_substring.tests
+++ b/shell/hush_test/hush-vars/param_expand_bash_substring.tests
@@ -11,7 +11,7 @@ export var=0123456789
 "$THIS_SH" -c 'echo ${var:}' SHELL
 
 # then some funky ones
-# UNFIXED BUG: this should work: "$THIS_SH" -c 'echo ${?:0}'
+"$THIS_SH" -c 'echo ${?:0}' SHELL
 
 # now some valid ones
 set --; echo "1    =|${1}|"


More information about the busybox-cvs mailing list