[git commit] lzop: checksum reads do not need to be checksummed

Denys Vlasenko vda.linux at googlemail.com
Sun Apr 8 11:45:04 UTC 2018


commit: https://git.busybox.net/busybox/commit/?id=15684bf5456a7cd12355da0b49cfdcdaf6463e11
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
do_lzo_decompress                                    404     427     +23
f_read32                                              22       -     -22

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 archival/lzop.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/archival/lzop.c b/archival/lzop.c
index e724b9edf..acf01829d 100644
--- a/archival/lzop.c
+++ b/archival/lzop.c
@@ -921,7 +921,7 @@ static void write_header(header_t *h)
 
 	h->flags32 = htonl(h->flags32); /* native endianness for lzo_compress() */
 
-	/*f_*/write32(chksum_getresult(h->flags32));
+	write32(chksum_getresult(h->flags32));
 }
 
 static int read_header(header_t *h)
@@ -986,7 +986,7 @@ static int read_header(header_t *h)
 	/* UNUSED h->len_and_name[1+l] = 0; */
 
 	checksum = chksum_getresult(h->flags32);
-	if (f_read32() != checksum)
+	if (read32() != checksum)
 		return 2;
 
 	/* skip extra field [not used yet] */
@@ -1002,7 +1002,7 @@ static int read_header(header_t *h)
 		for (k = 0; k < extra_field_len; k++)
 			f_read(&dummy, 1);
 		checksum = chksum_getresult(h->flags32);
-		extra_field_checksum = f_read32();
+		extra_field_checksum = read32();
 		if (extra_field_checksum != checksum)
 			return 3;
 	}


More information about the busybox-cvs mailing list