[Bug 10381] (patch inside) lineedit: multiline PS1: fix extra scrolls

bugzilla at busybox.net bugzilla at busybox.net
Mon Oct 9 20:34:08 UTC 2017


avih <avihpit at yahoo.com> changed:

           What    |Removed                     |Added
   Attachment #7271|0                           |1
        is obsolete|                            |

--- Comment #2 from avih <avihpit at yahoo.com> ---
Created attachment 7276
  --> https://bugs.busybox.net/attachment.cgi?id=7276&action=edit
lineedit: multiline PS1: fix extra scrolls - redraw using  last PS1 line (v3)

I noticed two issues with my previous patch:

- Other than after ^L, we also need the full prompt after displaying
tab-completion choices, since we don't render it in-place.

- The input_backward function, if ENABLE_UNICODE_WIDE_WCHARS, is printing the
prompt itself, which was all the prompt lines with my previous patch.

Patch v3 refactors the code slightly, which I think makes it cleaner, and also
addressed the issues above - explicitly with tab-completions, implicitly with
input_backward (now the patch doesn't change cmdedit_prompt to point to
cmdedit_prompt_full, even not temporarily, so input_backward doesn't
accidentally print the full prompt).

This patch applies on top of busybox git master, and so will have a context
conflict if applied on top of the patch at bug 10376 .

You are receiving this mail because:
You are on the CC list for the bug.

More information about the busybox-cvs mailing list