[git commit] script: -f means "flush", not "fsync"

Denys Vlasenko vda.linux at googlemail.com
Mon Aug 7 00:21:34 UTC 2017


commit: https://git.busybox.net/busybox/commit/?id=4dea1edd08a45c5987448719e56ee61a20fb9210
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
packed_usage                                       31765   31768      +3
script_main                                         1102    1082     -20

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 util-linux/script.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/util-linux/script.c b/util-linux/script.c
index 62a2417..89b4391 100644
--- a/util-linux/script.c
+++ b/util-linux/script.c
@@ -27,7 +27,8 @@
 //usage:     "\n"
 //usage:     "\n	-a	Append output"
 //usage:     "\n	-c PROG	Run PROG, not shell"
-//usage:     "\n	-f	Flush output after each write"
+/* Accepted but has no effect (we never buffer output) */
+/*//usage:     "\n	-f	Flush output after each write"*/
 //usage:     "\n	-q	Quiet"
 //usage:     "\n	-t[FILE] Send timing to stderr or FILE"
 
@@ -178,9 +179,10 @@ int script_main(int argc UNUSED_PARAM, char **argv)
 					}
 					full_write(STDOUT_FILENO, buf, count);
 					full_write(outfd, buf, count);
-					if (opt & OPT_f) {
-						fsync(outfd);
-					}
+					// If we'd be using (buffered) FILE i/o, we'd need this:
+					//if (opt & OPT_f) {
+					//	fflush(outfd);
+					//}
 				}
 			}
 			if (pfd[1].revents) {


More information about the busybox-cvs mailing list