[git commit] i2cdump: don't use common_bufsiz1

Denys Vlasenko vda.linux at googlemail.com
Fri Jun 24 01:58:43 UTC 2016

commit: https://git.busybox.net/busybox/commit/?id=59f81976249a85cf02bd73c2395f018033069466
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Commit e6a2f4cc changed the way common_bufsiz1 works. Now it needs to
be initialized before using, but i2cdump wasn't updated by said patch.

Since the fact that we're using common_bufsiz1 here isn't obvious (no
G_INIT() macro, no other global variables), drop it and simply
allocate the integer array required for block reads on the stack.

Tested with i2c block read on a Lenovo Thinkpad laptop.

Signed-off-by: Bartosz Golaszewski <bartekgola at gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
 miscutils/i2c_tools.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index 57bb72a..7731466 100644
--- a/miscutils/i2c_tools.c
+++ b/miscutils/i2c_tools.c
@@ -908,7 +908,7 @@ int i2cdump_main(int argc UNUSED_PARAM, char **argv)
 	int bus_num, bus_addr, mode = I2C_SMBUS_BYTE_DATA, even = 0, pec = 0;
 	unsigned first = 0x00, last = 0xff, opts;
-	int *block = (int *)bb_common_bufsiz1;
+	int block[I2CDUMP_NUM_REGS];
 	char *opt_r_str, *dash;
 	int fd, res;

More information about the busybox-cvs mailing list