[git commit] find_applet_by_name: loop index should be signed

Denys Vlasenko vda.linux at googlemail.com
Sun Apr 3 20:29:35 UTC 2016


commit: https://git.busybox.net/busybox/commit/?id=b22061718db0111f9e7474f9b60aef02456ac070
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

The loop

   for (j = ARRAY_SIZE(applet_nameofs)-1; j >= 0; j--) {

was intended to terminate when j goes negative, so j needs to be signed.

Signed-off-by: Ron Yorston <rmy at pobox.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 libbb/appletlib.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index d798a2e..de654f6 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -141,7 +141,8 @@ void FAST_FUNC bb_show_usage(void)
 
 int FAST_FUNC find_applet_by_name(const char *name)
 {
-	unsigned i, j, max;
+	unsigned i, max;
+	int j;
 	const char *p;
 
 /* The commented-out word-at-a-time code is ~40% faster, but +160 bytes.


More information about the busybox-cvs mailing list