[git commit] trylink: use mktemp instead of hardcoding paths

Mike Frysinger vapier at gentoo.org
Mon Mar 16 21:46:17 UTC 2015


commit: http://git.busybox.net/busybox/commit/?id=4a08e82d441dbde5412eca6a6db894b420f203f3
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

This way we respect standard tempdir env vars and are guaranteed to
be unique.

Signed-off-by: Mike Frysinger <vapier at gentoo.org>
---
 scripts/trylink |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/trylink b/scripts/trylink
index 5da494f..5a67fcf 100755
--- a/scripts/trylink
+++ b/scripts/trylink
@@ -46,7 +46,7 @@ try() {
 }
 
 check_cc() {
-    local tempname="/tmp/temp.$$.$RANDOM"
+    local tempname="$(mktemp)"
     # Can use "-o /dev/null", but older gcc tend to *unlink it* on failure! :(
     # "-xc": C language. "/dev/null" is an empty source file.
     if $CC $1 -shared -xc /dev/null -o "$tempname".o >/dev/null 2>&1; then
@@ -54,11 +54,11 @@ check_cc() {
     else
 	echo "$2";
     fi
-    rm "$tempname".o 2>/dev/null
+    rm -f "$tempname" "$tempname".o
 }
 
 check_libc_is_glibc() {
-    local tempname="/tmp/temp.$$.$RANDOM"
+    local tempname="$(mktemp)"
     echo "\
 	#include <stdlib.h>
 	/* Apparently uclibc defines __GLIBC__ (compat trick?). Oh well. */
@@ -71,7 +71,7 @@ check_libc_is_glibc() {
     else
 	echo "$1";
     fi
-    rm "$tempname".c "$tempname".o 2>/dev/null
+    rm -f "$tempname" "$tempname".[co]
 }
 
 EXE="$1"


More information about the busybox-cvs mailing list