[Bug 8261] New: vlan creation with proto option is not working

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=8261

           Summary: vlan creation with proto option is not working
           Product: Busybox
           Version: 1.24.x
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P5
         Component: Networking
        AssignedTo: unassigned at busybox.net
        ReportedBy: a.dibacco at gmail.com
                CC: busybox-cvs at busybox.net
   Estimated Hours: 0.0


Try to issue the following command:

iplink add link eth0 eth0.24 type vlan proto 802.1ad id 24

It answers with:

argument of "protocol" must be "on" or "off"


I saw that in iplink.c in function vlan_parse_opt the keywords array and
related enum are not consistent. ARG_protocol is listed at the end of enum and
should be at the second place.

static void vlan_parse_opt(char **argv, struct nlmsghdr *n, unsigned int size)
{
    static const char keywords[] ALIGN1 =
        "id\0"
        "protocol\0"
        "reorder_hdr\0"
        "gvrp\0"
        "mvrp\0"
        "loose_binding\0"
    ;

    enum {
        ARG_id = 0,
        ARG_reorder_hdr,
        ARG_gvrp,
        ARG_mvrp,
        ARG_loose_binding,
        ARG_protocol,
    };

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.