[Bug 4273] New: DHCP Client: "xid" would be better to change per "dialog" window

bugzilla at busybox.net bugzilla at busybox.net
Thu Sep 29 05:54:04 UTC 2011


           Summary: DHCP Client: "xid" would be better to change per
                    "dialog" window
           Product: Busybox
           Version: 1.15.x
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P4
         Component: Networking
        AssignedTo: unassigned at busybox.net
        ReportedBy: bspitz at yahoo.com
                CC: busybox-cvs at busybox.net
   Estimated Hours: 0.0

In networking/udhcp/dhcpc.c:
  I can see that the "xid" is randomly created at discovery, but then we just
use the same xid for ever. Ideally it would be better to increment the xid
after each ACK or NAK, to make the next "dialog window" we use unquie from
previous "dialog" window. RFC say this could actually be incremented every
message we send, but i have seen most clients just increment this per dialog
I am using busybox 1.11.2, but do not see any note of change up to 1.19.2. This
is 2 lines of code change, and keeps the xid more unquie per dialog window.
Also once we have processed a ACK or NAK, then the moving xid would make sure
we do not accpets a redundant ACK, NAK.
Also note that i belive should check that xid is never 0, not sure what RFC
says about that, but ensuring non zero value is probably best.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the busybox-cvs mailing list