[Bug 4436] New: Build failure if history file disabled

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=4436

           Summary: Build failure if history file disabled
           Product: Busybox
           Version: unspecified
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
        AssignedTo: unassigned at busybox.net
        ReportedBy: mr.nckx at gmail.com
                CC: busybox-cvs at busybox.net
   Estimated Hours: 0.0


The latest git version of Busybox refuses to build if (at least) shell history
is enabled but a history file is not.

In libbb/lineedit.c, cnt_history_in_file is accessed even if
ENABLE_FEATURE_EDITING_SAVEHISTORY is disabled:

  libbb/lineedit.c: In function ‘remember_in_history’:
  libbb/lineedit.c:1523:47: error: ‘line_input_t’ has no member named
‘cnt_history_in_file’
  libbb/lineedit.c:1524:39: error: ‘line_input_t’ has no member named
‘cnt_history_in_file’
  make[1]: *** [libbb/lineedit.o] Error 1

The solution is to replace

  if (ENABLE_FEATURE_EDITING_SAVE_ON_EXIT && state->cnt_history_in_file)
    state->cnt_history_in_file--;

with

  # if ENABLE_FEATURE_EDITING_SAVEHISTORY
  if (ENABLE_FEATURE_EDITING_SAVE_ON_EXIT && state->cnt_history_in_file)
    state->cnt_history_in_file--;
  # endif

on line 1523 of libbb/lineedit.c.

I've just started learning git this morning; creating a patch, let alone one
that would apply properly, is a bit too daunting at the moment.

   nckx

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.