[git commit] inetd: add FIXMEs

Denys Vlasenko vda.linux at googlemail.com
Thu May 12 21:05:27 UTC 2011

commit: http://git.busybox.net/busybox/commit/?id=b1ab283f0b6acc6610d64ec33a50c7b16e517797
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
 networking/inetd.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/networking/inetd.c b/networking/inetd.c
index 226a649..58ae089 100644
--- a/networking/inetd.c
+++ b/networking/inetd.c
@@ -1164,12 +1164,17 @@ int inetd_main(int argc UNUSED_PARAM, char **argv)
 	sigaddset(&sa.sa_mask, SIGALRM);
 	sigaddset(&sa.sa_mask, SIGCHLD);
 	sigaddset(&sa.sa_mask, SIGHUP);
+//FIXME: explain why no SA_RESTART
+//FIXME: retry_network_setup is unsafe to run in signal handler (many reasons)!
 	sa.sa_handler = retry_network_setup;
 	sigaction_set(SIGALRM, &sa);
+//FIXME: reread_config_file is unsafe to run in signal handler(many reasons)!
 	sa.sa_handler = reread_config_file;
 	sigaction_set(SIGHUP, &sa);
+//FIXME: reap_child is unsafe to run in signal handler (uses stdio)!
 	sa.sa_handler = reap_child;
 	sigaction_set(SIGCHLD, &sa);
+//FIXME: clean_up_and_exit is unsafe to run in signal handler (uses stdio)!
 	sa.sa_handler = clean_up_and_exit;
 	sigaction_set(SIGTERM, &sa);
 	sa.sa_handler = clean_up_and_exit;

More information about the busybox-cvs mailing list