[git commit] ash: add comment about bash's ENOEXEC handling. No code changes

Denys Vlasenko vda.linux at googlemail.com
Thu Dec 15 23:25:17 UTC 2011


commit: http://git.busybox.net/busybox/commit/?id=2bef526331a194da199993ec747598f625a5a9a8
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/shell/ash.c b/shell/ash.c
index 14472cb..d02b74a 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -7435,6 +7435,12 @@ tryexec(IF_FEATURE_SH_STANDALONE(int applet_no,) char *cmd, char **argv, char **
 		 *
 		 * That is, do not use $SHELL, user's shell, or /bin/sh;
 		 * just call ourselves.
+		 *
+		 * Note that bash reads ~80 chars of the file, and if it sees
+		 * a zero byte before it sees newline, it doesn't try to
+		 * interpret it, but fails with "cannot execute binary file"
+		 * message. For one, it prevents atempts to interpret
+		 * foreign ELF binaries as shell scripts.
 		 */
 		char **ap;
 		char **new;


More information about the busybox-cvs mailing list