[git commit] wget: add a note about bug 3625

Denys Vlasenko vda.linux at googlemail.com
Sat Apr 16 17:31:08 UTC 2011


commit: http://git.busybox.net/busybox/commit/?id=d506897b4ef94a85013696d543686162293a02f1
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/wget.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/networking/wget.c b/networking/wget.c
index 3a4be98..df6d363 100644
--- a/networking/wget.c
+++ b/networking/wget.c
@@ -661,6 +661,12 @@ static void download_one_url(const char *url)
 
 #if ENABLE_FEATURE_WGET_AUTHENTICATION
 		if (target.user) {
+//TODO: URL-decode "user:password" string before base64-encoding:
+//wget http://test:my%20pass@example.com should send
+// Authorization: Basic dGVzdDpteSBwYXNz
+//which decodes to "test:my pass", instead of what we send now:
+// Authorization: Basic dGVzdDpteSUyMHBhc3M=
+//Can reuse decodeString() from httpd.c
 			fprintf(sfp, "Proxy-Authorization: Basic %s\r\n"+6,
 				base64enc(target.user));
 		}
-- 
1.7.3.4



More information about the busybox-cvs mailing list