[git commit master] gen_build_files.sh uses bashism, document it

Denys Vlasenko vda.linux at googlemail.com
Sat May 15 19:08:51 UTC 2010


commit: http://git.busybox.net/busybox/commit/?id=084e2284c700561732cc708ee557169be9d18308
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 scripts/gen_build_files.sh |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/gen_build_files.sh b/scripts/gen_build_files.sh
index 73c9916..ea14de5 100755
--- a/scripts/gen_build_files.sh
+++ b/scripts/gen_build_files.sh
@@ -1,4 +1,7 @@
-#!/bin/sh
+#!/bin/bash
+# bashism:
+# "read -r" without variable name reads line into $REPLY
+# without stripping whitespace.
 
 test $# -ge 2 || { echo "Syntax: $0 SRCTREE OBJTREE"; exit 1; }
 
@@ -7,9 +10,7 @@ cd -- "$2" || { echo "Syntax: $0 SRCTREE OBJTREE"; exit 1; }
 
 srctree="$1"
 
-find -type d | while read -r; do
-	d="$REPLY"
-
+find -type d | while read -r d; do
 	src="$srctree/$d/Kbuild.src"
 	dst="$d/Kbuild"
 	if test -f "$src"; then
@@ -49,7 +50,6 @@ find -type d | while read -r; do
 			mv -- "$dst.$$.tmp" "$dst"
 		fi
 	fi
-
 done
 
 # Last read failed. This is normal. Don't exit with its error code:
-- 
1.6.3.3



More information about the busybox-cvs mailing list