[git commit master 1/1] testsuite: typo in tr.tests

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Thu Jul 29 08:11:09 UTC 2010


commit: http://git.busybox.net/busybox/commit/?id=1538c975ec127efc368284abe0777006719bf505
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Hi

tr.tests script from bb 1.17 testsuite has wrong "optional"
conditional clauses. As result, some tr tests was skipped even if
CONFIG_FEATURE_TR_CLASSES=y. Patch attached fixes problem for me.

- Leonid

Signed-off-by: Leonid Lisovskiy <lly.dev at gmail.com>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
---
 testsuite/testing.sh |    2 +-
 testsuite/tr.tests   |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/testsuite/testing.sh b/testsuite/testing.sh
index 913d7f8..f907dea 100644
--- a/testsuite/testing.sh
+++ b/testsuite/testing.sh
@@ -26,7 +26,7 @@
 # number of failed tests.
 
 # The "optional" function is used to skip certain tests, ala:
-#   optional CONFIG_FEATURE_THINGY
+#   optional FEATURE_THINGY
 #
 # The "optional" function checks the environment variable "OPTIONFLAGS",
 # which is either empty (in which case it always clears SKIP) or
diff --git a/testsuite/tr.tests b/testsuite/tr.tests
index a1f83bf..5dabbb5 100755
--- a/testsuite/tr.tests
+++ b/testsuite/tr.tests
@@ -15,19 +15,19 @@ testing "tr understands 0-9A-F" \
 	"tr -cd '[0-9A-F]'" \
 	"19AF" "" "19AFH\n"
 
-optional CONFIG_FEATURE_TR_CLASSES
+optional FEATURE_TR_CLASSES
 testing "tr understands [:xdigit:]" \
 	"tr -cd '[:xdigit:]'" \
 	"19AF" "" "19AFH\n"
 SKIP=
 
-optional CONFIG_FEATURE_TR_CLASSES
+optional FEATURE_TR_CLASSES
 testing "tr does not stop after [:digit:]" \
 	"tr '[:digit:]y-z' 111111111123" \
 	"111abcx23\n" "" "789abcxyz\n"
 SKIP=
 
-optional CONFIG_FEATURE_TR_CLASSES
+optional FEATURE_TR_CLASSES
 testing "tr has correct xdigit sequence" \
 	"tr '[:xdigit:]Gg' 1111111151242222333330xX" \
 	"#1111111151242222x333330X\n" "" \
-- 
1.7.1



More information about the busybox-cvs mailing list