[Bug 629] Non-compliant DHCP servers and udhcpc

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=629





--- Comment #1 from Nigel Hathaway <nhathaway at ubiquisys.com>  2009-09-30 11:22:38 UTC ---
To be more specific on this:

In networking/udhcp/dhcpc.c, there is a section for the code that looks like
this:

                        case REBINDING:
                                /* Lease is *really* about to run out,
                                 * try to find DHCP server using broadcast */
                                if (timeout > 0) {
                                        /* send a request packet */
                                        send_renew(xid, 0 /*INADDR_ANY*/,
requested_ip); /* broadcast */
                                        timeout >>= 1;
                                        continue;
                                }
                                /* Timed out, enter init state */
                                bb_info_msg("Lease lost, entering init state");
                                udhcp_run_script(NULL, "deconfig");
                                change_listen_mode(LISTEN_RAW);
                                state = INIT_SELECTING;

The line "change_listen_mode(LISTEN_RAW);" should really be moved to just below
"/* send a request packet */". This is because, if you send a request on
broadcast, you would expect a reply on broadcast.

Does this make sense? Have I missed anything?


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.