[git commit master] libbb: smaller isdigit. -95 bytes

Denys Vlasenko vda.linux at googlemail.com
Fri Oct 23 00:22:03 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=7b4cd6f7b07b816c4b36d686fe47c5cfec7f5abf
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 include/libbb.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/libbb.h b/include/libbb.h
index fb7296f..ad0d59d 100644
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -1579,9 +1579,10 @@ extern const char bb_default_login_shell[];
 #undef isupper
 #undef isxdigit
 
-/* This one is more efficient - we save ~400 bytes */
+/* This one is more efficient - we save ~500 bytes.
+ * BTW, x86 likes (unsigned char) cast more than (unsigned). */
 #undef isdigit
-#define isdigit(a) ((unsigned)((a) - '0') <= 9)
+#define isdigit(a) ((unsigned char)((a) - '0') <= 9)
 
 /* This one is more efficient too! ~200 bytes */
 /* In POSIX/C locale (the only locale we care about: do we REALLY want
-- 
1.6.3.3



More information about the busybox-cvs mailing list