[git commit master] mkfs_ext2: small tweak

Denys Vlasenko vda.linux at googlemail.com
Mon Oct 19 22:16:24 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=69f2e2cdeba8237d51fe63aa32efbd178ce02663
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 util-linux/mkfs_ext2.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/util-linux/mkfs_ext2.c b/util-linux/mkfs_ext2.c
index d0ebc1d..e840f78 100644
--- a/util-linux/mkfs_ext2.c
+++ b/util-linux/mkfs_ext2.c
@@ -75,10 +75,11 @@ static unsigned int_log2(unsigned arg)
 }
 
 // taken from mkfs_minix.c. libbb candidate?
-static unsigned div_roundup(uint64_t size, uint32_t n)
+// why "uint64_t size"? we never use it for anything >32 bits
+static uint32_t div_roundup(uint64_t size, uint32_t n)
 {
 	// Overflow-resistant
-	uint64_t res = size / n;
+	uint32_t res = size / n;
 	if (res * n != size)
 		res++;
 	return res;
-- 
1.6.3.3



More information about the busybox-cvs mailing list