svn commit: branches/busybox_1_13_stable/sysklogd

vda at busybox.net vda at busybox.net
Wed Mar 4 01:33:22 UTC 2009


Author: vda
Date: 2009-03-04 01:33:22 +0000 (Wed, 04 Mar 2009)
New Revision: 25519

Log:
syslogd: fix new log file mode 0600 -> 0666 (as usual, affected by umask)



Modified:
   branches/busybox_1_13_stable/sysklogd/syslogd.c


Changeset:
Modified: branches/busybox_1_13_stable/sysklogd/syslogd.c
===================================================================
--- branches/busybox_1_13_stable/sysklogd/syslogd.c	2009-03-04 01:31:48 UTC (rev 25518)
+++ branches/busybox_1_13_stable/sysklogd/syslogd.c	2009-03-04 01:33:22 UTC (rev 25519)
@@ -301,17 +301,23 @@
 	}
 #endif
 	if (G.logFD >= 0) {
+		/* Reopen log file every second. This allows admin
+		 * to delete the file and not worry about restarting us.
+		 * This costs almost nothing since it happens
+		 * _at most_ once a second.
+		 */
 		if (!now)
 			now = time(NULL);
 		if (G.last_log_time != now) {
-			G.last_log_time = now; /* reopen log file every second */
+			G.last_log_time = now;
 			close(G.logFD);
 			goto reopen;
 		}
 	} else {
  reopen:
-		G.logFD = device_open(G.logFilePath, O_WRONLY | O_CREAT
-					| O_NOCTTY | O_APPEND | O_NONBLOCK);
+		G.logFD = open(G.logFilePath, O_WRONLY | O_CREAT
+					| O_NOCTTY | O_APPEND | O_NONBLOCK,
+					0666);
 		if (G.logFD < 0) {
 			/* cannot open logfile? - print to /dev/console then */
 			int fd = device_open(DEV_CONSOLE, O_WRONLY | O_NOCTTY | O_NONBLOCK);



More information about the busybox-cvs mailing list