[git commit] install: compat fix for mode of created files.

Denys Vlasenko vda.linux at googlemail.com
Mon Jun 15 16:13:51 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=1f363a086779152ab04067e81484b8bb69e4af72
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master


By Mat Hostetter (mhostetter AT tilera.com)

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 coreutils/install.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/coreutils/install.c b/coreutils/install.c
index 24fb402..2e604be 100644
--- a/coreutils/install.c
+++ b/coreutils/install.c
@@ -129,7 +129,7 @@ int install_main(int argc, char **argv)
 	if (opts & OPT_PRESERVE_TIME) {
 		copy_flags |= FILEUTILS_PRESERVE_STATUS;
 	}
-	mode = 0666;
+	mode = 0755; /* GNU coreutils 6.10 compat */
 	if (opts & OPT_MODE)
 		bb_parse_mode(mode_str, &mode);
 	uid = (opts & OPT_OWNER) ? get_ug_id(uid_str, xuname2uid) : getuid();
@@ -175,8 +175,9 @@ int install_main(int argc, char **argv)
 			}
 		}
 
-		/* Set the file mode */
-		if ((opts & OPT_MODE) && chmod(dest, mode) == -1) {
+		/* Set the file mode (always, not only with -m).
+		 * GNU coreutils 6.10 is not affected by umask. */
+		if (chmod(dest, mode) == -1) {
 			bb_perror_msg("can't change %s of %s", "permissions", dest);
 			ret = EXIT_FAILURE;
 		}
-- 
1.6.0.6


More information about the busybox-cvs mailing list